Pastoray commented on code in PR #27273: URL: https://github.com/apache/datafusion/pull/27273#discussion_r4543282069
########## datafusion/spark/src/function/string/encode.rs: ########## Review Comment: I matched Spark itself: both legacy configs default to false in Spark 4, and the unmapped character case returns wrong bytes. But it is a breaking change for DataFusion users. If you’d prefer a transition, I can default both options to true for one release and flip them in the next. Which do you prefer ? ########## datafusion/common/src/config.rs: ########## Review Comment: Not entirely. It accepts Java’s aliases for the nine charsets encode supports, not every Java charset. I kept the name because it mirrors `spark.sql.legacy.javaCharsets`, but I can change the docs to say exactly that, or rename it if you think that is clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
