andygrove commented on code in PR #7352: URL: https://github.com/apache/datafusion-comet/pull/7352#discussion_r4543448453
########## docs/source/contributor-guide/ci.md: ########## @@ -177,6 +176,38 @@ If you cannot enable Actions on your fork, say so on the pull request. Nothing e tier for you before the queue does, so a maintainer may ask you to reproduce a failure with [`dev/local-ci.sh`](#reproducing-a-suite-failure-locally) first. +### When the fork check finds no run + +When no run of your fork exists for the pull request's head commit, `CI (fork)` says one of two +things: + +- **Enable CI on your fork.** Your fork has no enabled `Comet CI (fork run)` workflow. Usually + GitHub Actions was never enabled on the fork, or no branch that includes the fork workflows has + been pushed to it. GitHub shows this check as failed because it asks you to act. It does not block + merging, but the PR tier has not run on this commit anywhere, so a reviewer has no CI result to Review Comment: Good point. The first bullet no longer says that the PR tier has not run anywhere. It says the check only means that no run of the fork was found for this commit, and that a pull request opened before the PR tier moved to forks can still have upstream results. The rollout paragraph now describes both outcomes: the failed **Enable CI on your fork** check when the fork has no enabled workflow, and the neutral **No fork CI run for this commit** one when it has, which is what #7326 got (5070f61431). ########## docs/source/contributor-guide/development.md: ########## @@ -648,7 +648,9 @@ changes before retrying; do not switch to `--force` to bypass the check. For a pull request from a fork, the pull request tier of CI runs on your fork's GitHub runners rather than the project's. Enable GitHub Actions on your fork and keep its `main` in sync before you -push; see [Pull requests from forks](ci.md#pull-requests-from-forks). +push; see [Pull requests from forks](ci.md#pull-requests-from-forks). Until you do, the pull +request shows a failed `CI (fork)` check that says **Enable CI on your fork**, and the PR tier Review Comment: Qualified. The paragraph is about a pull request from a fork that targets `main`, and it says that one that targets a release branch keeps the PR tier on the project's runners and has no `CI (fork)` check. `ci.md` already says that a release branch keeps the PR tier here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
