vinycalves commented on code in PR #27360: URL: https://github.com/apache/datafusion/pull/27360#discussion_r4551346394
########## datafusion/physical-plan/src/aggregates/group_values/multi_group_by/bytes_view.rs: ########## Review Comment: The offset shift is subtracted from every non-inlined view. Does that rely on all remaining views pointing to the in-progress buffer, and is the mixed completed/in-progress case tested? Also, is drain O(n^2) when many groups remain across repeated partial emits? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
