Phoenix500526 commented on code in PR #27117:
URL: https://github.com/apache/datafusion/pull/27117#discussion_r4551482497
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -1132,7 +1134,9 @@ impl OptimizerRule for PushDownFilter {
let mut push_predicates = vec![];
for expr in predicates {
let cols = expr.column_refs();
+ // A false predicate below a grand total still leaves a
result row.
if !expr.is_volatile()
+ && (!cols.is_empty() || !emits_on_empty)
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
