chinmaydwivedi opened a new pull request, #27378: URL: https://github.com/apache/datafusion/pull/27378
## Which issue does this PR close? Part of #27239. I claimed this file [here](https://github.com/apache/datafusion/issues/27239#issuecomment-6824270257); the rest of the datetime folder is covered by #27336. #27263 also touches this file, but it converts all 65 files in one go, which the issue asks people to avoid, and it currently has merge conflicts. So I kept this PR to the one file. ## Rationale for this change When the whole error message is written as an escaped regex, like `Interval\(MonthDayNano\) \+ Utf8`, it's hard to read and hard to review. Writing it as plain text after `----` makes the expected error easy to read, and the check becomes an exact match. ## What changes are included in this PR? In `datetime/timestamps.slt`, 7 of the 12 checks that carried the full message as an escaped regex now show it as plain text. The other 5 stay as regexes because they only match part of the error on purpose: - Two use `[\s\S]*` to skip over the middle of the message. - Three (`make_date`, `make_time`, `to_local_time`) stop before the "No function matches the given name and argument types ..." hint and the list of candidate functions that the real error prints after the first sentence. ## What is the testing strategy for this PR? Only test expectations change. I removed the message from each check, ran `--complete` to fill in the actual error, and kept the new block only when it matched the old regex with the escapes taken out. Then I ran the file normally: cargo test --test sqllogictests -- datetime/timestamps.slt The full sqllogictest suite also passes locally. ## Are there any user-facing changes? No, this only changes a test file. I used AI assistance (Claude Code) for this change and reviewed the result before opening the PR. This is my first DataFusion PR, so a maintainer may need to approve the CI run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
