Inf1mum commented on issue #27239:
URL: https://github.com/apache/datafusion/issues/27239#issuecomment-6834566492
Unclaiming `encoding.slt` and `expr.slt`. All 4 matching lines (encoding.slt
65, 68, 83 and expr.slt 608) fail step 3 of the recipe: the actual error is
longer than the old regex. For example, `select encode(12, 'hex');` now fails
with
```
DataFusion error: Error during planning: Function 'encode' requires Binary,
but received Int64 (DataType: Int64).. No function matches the given name and
argument types 'encode(Int64, Utf8)'. You might need to add explicit type casts.
Candidate functions:
encode(Binary, String)
```
and `decode` (encoding.slt 68), `to_hex` (encoding.slt 83), and `repeat`
(expr.slt 608) have the same appended signature text. The inline regexes match
only a prefix of these messages, so the plain-text record cannot equal the old
regex with the escapes removed. The appended "No function matches …" text and
these exact slt lines both go back to
[#20605](https://github.com/apache/datafusion/pull/20605), so the regexes have
been prefix-matches ever since. Converting them would mean rewriting the checks
to the full multi-line message rather than a mechanical rewrite, so I'm
releasing the claim instead of opening an empty PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
