alamb commented on code in PR #12092:
URL: https://github.com/apache/datafusion/pull/12092#discussion_r1763015795
##########
datafusion/core/src/datasource/physical_plan/parquet/row_group_filter.rs:
##########
@@ -264,8 +264,12 @@ impl PruningStatistics for BloomFilterStatistics {
.iter()
.map(|value| {
match value {
- ScalarValue::Utf8(Some(v)) => sbbf.check(&v.as_str()),
- ScalarValue::Binary(Some(v)) => sbbf.check(v),
+ ScalarValue::Utf8(Some(v)) |
ScalarValue::Utf8View(Some(v)) => {
Review Comment:
Filed https://github.com/apache/datafusion/issues/12499
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -1034,14 +1034,22 @@ fn binary_to_string_coercion(
) -> Option<DataType> {
use arrow::datatypes::DataType::*;
match (lhs_type, rhs_type) {
+ // Note: added rules to coerce from BinaryView --> Utf8View
Review Comment:
Filed https://github.com/apache/datafusion/issues/12500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
