abp002 commented on PR #26967: URL: https://github.com/apache/datafusion/pull/26967#issuecomment-6835958508
Thanks for the review, and for the tests. I moved the promotion into `EquivalenceClass::push` and `extend`, so the four calls in `add_equal_conditions` are gone, and added the unit test, the window case and the two sort-merge join queries. All four queries fail on main and pass here. I also dropped the `IN` test: as you say, it still finishes with the bound replaced by `loop`, so it wasn't covering termination. Rebased on main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
