kumarUjjawal commented on code in PR #27025:
URL: https://github.com/apache/datafusion/pull/27025#discussion_r4559708941
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -96,6 +96,20 @@ pub fn combine_hashes(l: u64, r: u64) -> u64 {
/// to this size.
const MAX_BUFFER_SIZE: usize = 524_288;
+#[cfg(not(feature = "force_hash_collisions"))]
+fn dictionary_nulls<K: ArrowDictionaryKeyType>(
+ array: &DictionaryArray<K>,
+) -> (bool, bool) {
+ (
+ array.keys().null_count() != 0,
+ array.values().null_count() != 0,
+ )
+}
+
+fn dictionary_overwrites_hash_buffer(array: &dyn Array) -> bool {
Review Comment:
`dictionary_overwrites_hash_buffer` is no longer gated on
`force_hash_collisions` and returns true in that configuration.
Under `--features force_hash_collisions`, with_hashes skips `clear()` for
non-null dictionaries. It is harmless only because that build's
`hash_single_array` writes 0 to every slot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
