AdamGS commented on code in PR #27380:
URL: https://github.com/apache/datafusion/pull/27380#discussion_r4562139956
##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -2801,8 +2801,9 @@ mod tests {
/// an `expr_planners` method for `SessionState`.
#[tokio::test]
async fn test_with_expr_planners() -> Result<()> {
- // A helper method for planning count wildcard with or without expr
planners.
- async fn plan_count_wildcard(
+ // OVERLAY has no fallback in `SqlToRel`; only `CoreFunctionPlanner`,
+ // which is always registered, can plan it.
+ async fn plan_overlay(
Review Comment:
I've found this test to be weird, but I figured I'll stay cautions and keep
it in spirit.
It shows that you have to add `CoreFunctionPlanner` to the context for it to
manage to plan some build it functionality, which isn't true for `count(*)`
anymore so claude figured that `overaly` is such case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
