mbutrovich opened a new issue, #27406:
URL: https://github.com/apache/datafusion/issues/27406

   ### Describe the bug
   
   `tpchgen-cli` 4.0.0 (released 2026-10-19) moved the output format from 
`--format` to a subcommand and renamed `--parquet-compression` to 
`--compression`. `bench.sh` still uses the 3.x syntax in 
[`data_tpch`](https://github.com/apache/datafusion/blob/0a363f639eb87f84af98e307d7f85fdbf4a22b72/benchmarks/bench.sh#L773)
 for Parquet, [for 
CSV](https://github.com/apache/datafusion/blob/0a363f639eb87f84af98e307d7f85fdbf4a22b72/benchmarks/bench.sh#L785),
 and in [the sort pushdown 
data](https://github.com/apache/datafusion/blob/0a363f639eb87f84af98e307d7f85fdbf4a22b72/benchmarks/bench.sh#L1501).
 The install hint at [line 
752](https://github.com/apache/datafusion/blob/0a363f639eb87f84af98e307d7f85fdbf4a22b72/benchmarks/bench.sh#L752)
 runs `cargo install tpchgen-cli` without a version, so a new install gets 
4.0.0 and every TPC-H data target fails.
   
   ### To Reproduce
   
   ```shell
   cargo install tpchgen-cli --locked   # installs 4.0.0
   tpchgen-cli --scale-factor 1 --format parquet 
--parquet-compression='ZSTD(1)' --parts=1 --output-dir /tmp/tpch
   ```
   
   ```
   error: unexpected argument '--format' found
   
   Usage: tpchgen-cli --scale-factor <SCALE_FACTOR>
   
   For more information, try '--help'.
   ```
   
   `./bench.sh data tpch` fails the same way.
   
   ### Expected behavior
   
   `./bench.sh data tpch`, `data tpch10`, and the sort pushdown data target 
generate their data with the current `tpchgen-cli`.
   
   ### Additional context
   
   The 4.0 equivalents produce the same `<table>/<table>.<part>.<format>` 
layout that `bench.sh` expects (checked with 4.0.0):
   
   ```shell
   tpchgen-cli parquet -s "${SCALE_FACTOR}" --compression='ZSTD(1)' --parts=1 
--output-dir "${TPCH_DIR}"
   tpchgen-cli csv -s "${SCALE_FACTOR}" --parts=1 --output-dir "${TPCH_DIR}/csv"
   tpchgen-cli parquet -s 1 --compression='ZSTD(1)' --parts=3 --output-dir 
"${TEMP_DIR}"
   ```
   
   Should we switch to the 4.0 syntax and change the install hint to `cargo 
install tpchgen-cli@4`, so the hint and the commands stay in step?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to