Wali05 opened a new pull request, #101: URL: https://github.com/apache/datafusion-spark/pull/101
## Which issue does this PR close? Follows up on #84, per the review suggestion. ## Rationale for this change The approval on #84 asked for slt cases covering `Utf8View`, `LargeUtf8` and `BinaryView` inputs, plus edge cases like `'YQ= ='` and `'YQ-_'`. This adds those, along with `LargeBinary`, NULLs for each type, and a few more MIME-decoder cases: whitespace inside the input, trailing data after padding, and non-ASCII bytes. ## What changes are included in this PR? Tests only, in `crates/sqllogictest/test_files/string/base64.slt`. Expected values were checked against `java.util.Base64.getMimeDecoder()` on JDK 21. All of these input types already work, so no decoder changes were needed. `LargeUtf8` is coerced to `LargeBinary` and returns `LargeBinary`; `Utf8View` and `BinaryView` return `Binary`. ## What is the testing strategy for this PR? `cargo test -p datafusion-spark-sqllogictest -- base64` passes, as do `cargo fmt --all -- --check` and `cargo clippy --all-targets --all-features --workspace -- -D warnings`. ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
