Rich-T-kid commented on PR #26789:
URL: https://github.com/apache/datafusion/pull/26789#issuecomment-6862818740

   The first same-SHA TPC-H run showed the intended wins in Q1 and Q19, but Q16 
moved in the wrong direction under the stricter zero-regression gate:
   
   - Q1: 41.49 -> 40.06 ms minimum (-3.45%)
   - Q16: 13.92 -> 14.21 ms minimum (+2.08%)
   - Q19: 32.79 -> 30.47 ms minimum (-7.08%)
   
   Commit c37a2aada6b21adc699c3fd6d1ddb648c130ec84 removes the Q16-specific 
filtered grouping path while retaining the Q1 source-filtered grouping path and 
Q19 equality/IN filter-only path. It also adds negative coverage for the exact 
Q16 NOT LIKE shape at catalog selection and physical optimization.
   
   A fresh Q1-Q22 plan audit with RLE dictionary reads disabled now has only Q1 
visibly changing. Q16 and the other 20 queries are byte-identical with the 
optimizer off; Q19 remains textually identical because its dictionary 
representation is internal to the scan/filter boundary.
   
   The next benchmark compares this exact SHA against itself with only 
DATAFUSION_OPTIMIZER_ENABLE_DICTIONARY_PRESERVATION toggled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to