comphead opened a new pull request, #7620:
URL: https://github.com/apache/datafusion-comet/pull/7620

   ## Which issue does this PR close?
   
   Part of #7619.
   
   ## Rationale for this change
   
   apache/datafusion#27337 moved the `datafusion-spark` crate to 
[apache/datafusion-spark](https://github.com/apache/datafusion-spark), and its 
Spark-related issues moved with it. Comet's build is unaffected, because it 
takes the crate from crates.io and the name stays the same. But some docs and 
agent skills still say the crate lives in apache/datafusion. The 
`wire-datafusion-function` skill also looks for its sources at a path that 
DataFusion 57 no longer has.
   
   ## What changes are included in this PR?
   
   - `roadmap.md`, the `datafusion-comet-spark-expr` README and the top-level 
project proposal say that `datafusion-spark` lives in apache/datafusion-spark. 
The README linked to the 50.0.0 docs on docs.rs and now links to the repository.
   - `implement-comet-expression` names the new repository.
   - `wire-datafusion-function`: the local-clone lookup greps 
`datafusion/spark/src/function/` in a DataFusion clone. That works up to 56.x. 
At a DataFusion 57 or later tag the path is missing, and the grep returns 
nothing without an error. The skill now says so and adds the lookup in an 
apache/datafusion-spark clone (`crates/spark/src/function/`), with the same tag 
check.
   - Links to the two moved issues use their new numbers. 
apache/datafusion#25913 is now apache/datafusion-spark#32 (`xxhash64.rs`, 
`hash_funcs.md`), and apache/datafusion#25981 is now apache/datafusion-spark#34 
(`array_funcs.md`).
   
   The dependency itself does not change. 56.x is still released from 
apache/datafusion, and the DataFusion 57 items stay open in #7619.
   
   ## How are these changes tested?
   
   Documentation and comments only. `prettier --check` passes on the changed 
Markdown files, and `rustfmt --check` passes on `xxhash64.rs`.
   
   For the skill, the old lookup finds 90 matches at the DataFusion `55.2.0` 
tag and 0 at DataFusion `main` (`6c42917`). `crates/spark/src/function/` has 95 
matches at apache/datafusion-spark `main`. That repository has no release tags 
yet, so the new tag check prints its warning until 57.0.0 is tagged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to