andygrove opened a new pull request, #1832: URL: https://github.com/apache/datafusion-python/pull/1832
# Which issue does this PR close? N/A. Found while testing the DataFusion 56 upgrade (#1826). # Rationale for this change `tpchgen-cli` 4.0.0 (released 2026-10-19) moved the output format to a subcommand and removed the `--format` flag. The test workflow installs `tpchgen-cli` unpinned and runs `tpchgen-cli -s 1 --format=parquet`, which now fails: ``` error: unexpected argument '--format' found ``` No `abi3` test job has reached this step since that release. On #1826 it was skipped only because an earlier step failed, so it goes red as soon as that is fixed, and the same applies to any other PR. # What changes are included in this PR? In `.github/workflows/test.yml`: - `tpchgen-cli -s 1 --format=parquet` becomes `tpchgen-cli parquet -s 1`. - The install is pinned to `tpchgen-cli>=4,<5`, so a future major release can't break the step without a deliberate bump. The 4.x default output (one `<table>.parquet` per table in the current directory) is the same layout `examples/tpch` reads. I checked this locally: data generated with `tpchgen-cli parquet -s 1` passes all 22 TPC-H tests (`pytest examples/tpch/_tests.py`). # Are there any user-facing changes? No. CI only. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
