vikrantmehta123 opened a new pull request, #27430: URL: https://github.com/apache/datafusion/pull/27430
## Which issue does this PR close? - Closes #27195. ## Rationale for this change This PR fixes a query correctness bug. The issue details the bug. ## What changes are included in this PR? Previously, `TopKAggregation` followed the sort key through projections by name and skipped computed expressions. This caused the issue that if a computed expression was aliased to the aggregate's name, the rule could not distinguish the two. - `datafusion/physical-optimizer/src/topk_aggregation.rs`: the projection arm no longer loops over every expression to match on the name. It looks up the expression at the sort column's index. If that expression is not a plain `Column` then the optimization won't be applied. ## What is the testing strategy for this PR? Two SLTs are added in `datafusion/sqllogictest/test_files/aggregates_topk.slt`. One covers the query result and the other covers the query plans. The query used in the SLTs is the one from the issue." Tests were run before applying the fix to ensure that the bug exists and the tests catch the bug. ## Are there any user-facing changes? Yes, the query now returns correct output. No change in the public APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
