Visorgood commented on PR #6696: URL: https://github.com/apache/datafusion-comet/pull/6696#issuecomment-6879804985
Small correction to my previous comment: Iceberg 1.11's `BatchAppend` only implements `commit(messages)`, so it ignores the `MergeSummary` for appends. An insert-only MERGE on 4.1 confirms it: the snapshot is a plain `append` with no merge properties, with or without Comet. So the real loss on 4.2 is the native writer; passing a `MergeSummary` from `IcebergCommitExec` would only keep parity with Spark's `InsertOnlyMergeExec`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
