mohitgurav20 commented on PR #26000: URL: https://github.com/apache/datafusion/pull/26000#issuecomment-6882860336
thanks @alamb, addressed all three points in the latest commit: Rephrased the config doc to lead with the memory vs performance impact, moving the deeper background into SingleDistinctToGroupBy docs. Trimmed the comment on is_single_distinct_agg down to just the key eligibility rules. Replaced the verbose Rust plan-builder tests with EXPLAIN transcript queries in single_distinct_to_groupby.slt covering the same edge cases (un-grouped, strings, floats, unsupported UDAFs). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
