blaginin commented on code in PR #27437:
URL: https://github.com/apache/datafusion/pull/27437#discussion_r4575309014
##########
datafusion-cli/Cargo.toml:
##########
@@ -53,6 +53,9 @@ parking_lot = { workspace = true }
parquet = { workspace = true, default-features = false }
regex = { workspace = true }
rustyline = "19.0"
+tabled = { version = "0.22", default-features = false, features = ["std"] }
+terminal_size = "0.4.4"
+textwrap = { version = "0.16.4", default-features = false, features =
["unicode-width"] }
Review Comment:
new deps aren't great but:
- they are lightweights: +3s compilation time out of 12 minutes we already
have
- really hard to use cli otherwise
- in the future we can make tables prettier: as they support different
formatting styles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
