Rich-T-kid commented on PR #27445:
URL: https://github.com/apache/datafusion/pull/27445#issuecomment-6885915901

   Hosted benchmark result: this does not meet the bar for an upstream 
optimization.
   
   The existing partitioned ClickBench suite is the only major suite with 
queries that execute this dictionary MIN/MAX path. Its affected queries were 
all classified as no change:
   
   - Q21: 1463.31 ms -> 1450.92 ms (-0.85%)
   - Q22: 3409.54 ms -> 3439.95 ms (+0.89%)
   - Q28: 2686.15 ms -> 2654.67 ms (-1.17%)
   
   TPC-H classified all 22 queries as no change. TPC-DS was flat overall 
(9126.21 ms -> 9146.08 ms); its isolated faster/slower classifications were on 
queries that do not execute this string dictionary path. ClickBench likewise 
reported unrelated faster and slower queries, so its roughly 1% aggregate shift 
is not attributable to this change.
   
   Because the directly affected queries show no material or reproducible gain, 
the implementation complexity is not justified. Closing the draft rather than 
presenting unrelated suite noise as evidence.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to