Rich-T-kid commented on PR #27447: URL: https://github.com/apache/datafusion/pull/27447#issuecomment-6887772117
Hosted benchmark result: this does not provide evidence for the literal-regex optimization. None of the required suites executes the changed binary regex operators: - TPC-H contains no regex predicates. Total time was 760.79 ms -> 742.59 ms, with one unrelated query classified faster. - TPC-DS contains no regex predicates. Total time was 9530.21 ms -> 9874.84 ms, with 1 unrelated query faster and 31 unrelated queries slower. - Standard partitioned ClickBench does not use the changed operators. Its regex-related SQL calls REGEXP_REPLACE, which is a different UDF. Total time was 42949.39 ms -> 42416.78 ms, with 5 unrelated queries faster and 2 unrelated queries slower. Because no benchmark query enters this code path, none of the timing movement can be attributed to this patch. There is no clear evidence of an end-to-end speedup in the required suites, so I am closing the draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
