Rich-T-kid commented on PR #27448: URL: https://github.com/apache/datafusion/pull/27448#issuecomment-6887771985
Hosted benchmark result: this does not provide evidence for the encode/decode optimization. TPC-H, TPC-DS, and standard partitioned ClickBench contain no calls to encode or decode, so none of the required benchmark queries executes the changed path: - TPC-H: 837.02 ms -> 861.78 ms, with one unrelated query classified slower. - TPC-DS: 8461.12 ms -> 8483.35 ms, with all 99 queries classified no change in the primary comparison. - Partitioned ClickBench: 43062.63 ms -> 43024.51 ms, with 5 unrelated queries faster and 4 unrelated queries slower. The mixed movement is suite noise, not causal evidence for this patch. With no affected query and no attributable end-to-end speedup, I am closing the draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
