Rich-T-kid commented on PR #27449: URL: https://github.com/apache/datafusion/pull/27449#issuecomment-6887772021
Hosted benchmark result: this does not provide evidence for the scalar replace optimization. None of the required suites calls scalar replace. ClickBench Q28 calls REGEXP_REPLACE, which is a different UDF and cannot execute this patch: - TPC-H: 856.94 ms -> 846.32 ms, with 2 unrelated queries classified faster. - TPC-DS: 9283.24 ms -> 9343.58 ms, with one unrelated query classified slower. - Partitioned ClickBench: 38020.78 ms -> 38137.00 ms, with one unrelated query classified faster. Because no benchmark query enters the changed path, the isolated classifications cannot be attributed to dictionary-preserving replace. There is no clear evidence of an end-to-end speedup in the required suites, so I am closing the draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
