galaxytemple commented on PR #27450: URL: https://github.com/apache/datafusion/pull/27450#issuecomment-6889522412
Regarding `AggregateMode::Single`, initially, I also considered enabling dynamic filter for `AggregateMode::Single` as well (since single-partition plans can still scan across multiple Parquet files or row groups). However, seeing that `test_aggregate_dynamic_filter_not_created_for_single_mode` explicitly asserts against creating dynamic filters in `Single` mode, and allowing `Single` is slightly out of scope for the original issue. I kept `init_dynamic_filter` restricted to `AggregateMode::Partial` to preserve existing design. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
