andygrove commented on code in PR #2867: URL: https://github.com/apache/datafusion-ballista/pull/2867#discussion_r4579201249
########## docs/source/upgrading/56.0.0.md: ########## @@ -218,9 +218,9 @@ that holds data per partition from one that does not, such as a `FilterExec`. An interior node of your own that holds data per partition still returns wrong results in a split stage unless a resolver restricts it. -The error names the node and what to implement. Under push-staged scheduling -the job's status says only that a task could not be prepared; the reason is in -the scheduler's log. To make nodes of your own restrictable, see +The error, which the job's status carries under both push-staged and +pull-staged scheduling, names the node and what to implement. To make nodes of Review Comment: Thanks for closing this gap, the push-staged path now matches pull-staged nicely. The PR body mentions that a rejected job now fails with "task was rejected by executor <id>" instead of the old combined message. That old text shipped in 55.0.0. Could we add a sentence to `docs/source/upgrading/56.0.0.md` so anyone matching on it sees the change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
