comphead commented on PR #7520:
URL: 
https://github.com/apache/datafusion-comet/pull/7520#issuecomment-6900282374

   Correction to my review above: it was anchored to an earlier push of this 
branch (`0db2646e2d`), so its inline comments show as outdated. The current 
head `439104f9f4` is already rebased past #7516 and #7521 and merges cleanly 
with `main`, so please ignore the rebase and stale-tier paragraph in the 
summary.
   
   The five inline points still apply at `439104f9f4`:
   
   - `ci.yml` `iceberg_1_12` (line 623): nothing in the job fails if the native 
writer silently falls back again, since `summarize-iceberg-writes.py` never 
fails the job.
   - `IcebergReflection.scala` line 1975: `manifestReadMethodOf` calls 
`Class.getMethod` directly instead of the cached `getMethod` helper, and line 
1972 still says "1.5.2 through 1.12".
   - `DetectionDelegatingFileIO.java` line 71: is Java needed, given that Scala 
accepts `override` on an abstract member too?
   - `iceberg.md` line 39: "tested with ... 1.12" goes further than what CI 
runs.
   - `compute-changes.py` line 388: a fourth copy of the Iceberg path list.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to