bert-beyondloops commented on code in PR #26261:
URL: https://github.com/apache/datafusion/pull/26261#discussion_r4584509270


##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1902,14 +1902,18 @@ impl DefaultPhysicalPlanner {
                     // Use ordinary sort-merge join when hash join is not 
preferred.
                     // Null-aware joins not handled above fall back to 
CollectLeft
                     // HashJoin because their semantics are not supported by 
sort-merge join.
-                    let join_on_len = join_on.len();
+                    // The join keys are an unordered set of equalities, so 
they may be
+                    // reshuffled (together with their sort options) to match 
the input
+                    // orderings and avoid sorting.

Review Comment:
   removed the comments



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to