andygrove commented on PR #27428:
URL: https://github.com/apache/datafusion/pull/27428#issuecomment-6915568399

   @viirya Thanks! Addressed in 5a4be3e.
   
   1. **Backport target:** we open PRs against `main` and then backport to the 
release branch, so I'll backport this to `branch-56` before 56.0.0 is final, 
with the upgrade note in the 56 guide. That way 56.0.0 and later 56.0.x 
releases share one layout.
   2. **Foreign-expression coverage:** I added 
`foreign_requirements_met_by_foreign_child` in `ffi_integration`, which uses a 
real cdylib. With identity equality it fails `SanityCheckPlan`, and it passes 
with the new `FFI_PhysicalExpr::eq`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to