2010YOUY01 commented on PR #27170:
URL: https://github.com/apache/datafusion/pull/27170#issuecomment-6915857371

   > @2010YOUY01 do you feel this change in `SortExec` is still needed after 
your fix? I think it depends on whether plans are allowed to report 
"unexpected" plan information as long as their input requirements haven't been 
met.
   
   No, I think it's not needed.
   
   I believe we have to set the constraint: 'plan properties are not valid 
before EnsureRequirements', otherwise the property propagations, like what this 
PR did, would be really tricky to implement, at least I can't understand the 
change in this PR.
   
   I'm thinking if there are any ways to enforce it somehow 🤔  at least we can 
document it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to