andygrove opened a new pull request, #318:
URL: https://github.com/apache/datafusion-spark/pull/318

   ## Which issue does this PR close?
   
   Part of #56: the "Run `cargo test -p datafusion-spark` (unit tests and 
doctests)" item.
   
   ## Rationale for this change
   
   CI runs `cargo fmt`, `cargo clippy`, the license header check and the 
sqllogictest files, but not `cargo test -p datafusion-spark`. So the crate's 
unit tests (334 on current `main`) and doctests never run on pull requests. 
`AGENTS.md` asks contributors to run them before opening a PR, but nothing 
checks that they do.
   
   ## What changes are included in this PR?
   
   A new `.github/workflows/test.yml`, in the same style as `sqllogictest.yml`. 
It runs `cargo test -p datafusion-spark --all-features` on pull requests and on 
pushes to `main`. `--all-features` includes the `core` feature, so the 
`SessionStateBuilderSpark` tests also run.
   
   #56 has two related items that could become extra jobs in this workflow: 
checking that the crate builds with each feature combination, and building the 
docs with `RUSTDOCFLAGS="-D warnings"`. They are left out to keep this PR small.
   
   ## Are these changes tested?
   
   - `cargo test -p datafusion-spark --all-features` passes locally on current 
`main`: 334 unit tests and 4 doctests (1 ignored). It takes about 14 seconds 
with a warm build cache.
   - `actionlint` reports no problems with the workflow.
   - The workflow runs on this PR itself.
   
   ## Are there any user-facing changes?
   
   No.
   
   _This PR was written by an LLM (Claude) and reviewed before opening._
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to