andygrove opened a new pull request, #320:
URL: https://github.com/apache/datafusion-spark/pull/320

   ## Which issue does this PR close?
   
   Part of #56: the "Check that the crate builds with default features, with no 
default features, and with the `core` feature" item.
   
   ## Rationale for this change
   
   The clippy job builds with `--all-features`. Code that only compiles with 
every feature enabled, or that only compiles without warnings that way, passes 
CI. One example is an import used only under `#[cfg(feature = "core")]`. 
apache/datafusion checked the feature combinations of `datafusion-spark` in its 
`cargo check datafusion-spark features` job, and nothing replaced that check 
when the crate moved here.
   
   ## What changes are included in this PR?
   
   A `cargo check features` job in `.github/workflows/lint.yml`, with the same 
three checks as apache/datafusion:
   
   - default features, with `--all-targets`
   - `--no-default-features`, library only
   - `--no-default-features --features core`, library only
   
   It sets `RUSTFLAGS: -D warnings`, unlike the DataFusion job, so that a 
warning in one feature combination fails the check.
   
   `default = []` today, so the first two checks build the same features. The 
`--no-default-features` check keeps that combination covered if a default 
feature is added later.
   
   ## Are these changes tested?
   
   All three checks pass locally on current `main` with `RUSTFLAGS="-D 
warnings"`, and `actionlint` reports no problems. The job runs on this PR.
   
   ## Are there any user-facing changes?
   
   No.
   
   _This PR was written by an LLM (Claude) and reviewed before opening._
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to