andygrove opened a new pull request, #322:
URL: https://github.com/apache/datafusion-spark/pull/322

   ## Which issue does this PR close?
   
   Part of #56: the "Add the ASF action allowlist check, as in 
apache/datafusion-iceberg" item.
   
   ## Rationale for this change
   
   The ASF only lets GitHub Actions on the [ASF Infrastructure 
allowlist](https://github.com/apache/infrastructure-actions) run in its 
repositories. Without a check, a pull request that adds a workflow step using 
an action that isn't allowlisted, or that is pinned to a version that isn't 
approved, passes review. The workflow then fails to run after it merges.
   
   ## What changes are included in this PR?
   
   A new `.github/workflows/asf-allowlist-check.yml`, taken from 
apache/datafusion-iceberg. It runs 
`apache/infrastructure-actions/allowlist-check` on pull requests.
   
   The only differences from the datafusion-iceberg version:
   
   - It uses the short SPDX license header that our other workflows use.
   - It uses `actions/checkout@v4`, like our other workflows.
   - It has no `merge_group` trigger, since this repository doesn't use a merge 
queue.
   
   ## Are these changes tested?
   
   I checked the `uses:` refs of every workflow on `main` and in the open CI 
PRs (#318, #320, #321) against the current `approved_patterns.yml`:
   
   - **`actions/checkout`, `actions/setup-python` and `actions/setup-java`:** 
the check trusts everything under `actions/*` automatically.
   - **`Swatinem/rust-cache@v2`:** matches `Swatinem/rust-cache@*`.
   
   So the check should pass. `actionlint` reports no problems, and the workflow 
runs on this PR.
   
   ## Are there any user-facing changes?
   
   No.
   
   _This PR was written by an LLM (Claude) and reviewed before opening._
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to