Adam-Alani opened a new issue, #27475:
URL: https://github.com/apache/datafusion/issues/27475

   SQL evaluates `+`, `-`, `*`, `/`, `%`, and `power` from left to right. An 
n-ary Substrait call such as `add(a, b, c, d)` is that left spine written as 
one function.
   
   `from_scalar_function` rebuilds every `name_to_op` call with 
`arg_list_to_binary_op_tree`, which splits the argument list in half. For four 
arguments that is `(a op b) op (c op d)` rather than `((a op b) op c) op d`. 
Those shapes are not equal for floats.
   
   `power` does not go through `name_to_op`. It is a binary UDF, so an n-ary 
`power` call is handed every argument at once and does not match the 
two-argument signature.
   
   `and` and `or` are associative and should stay balanced.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to