comphead commented on PR #323:
URL: https://github.com/apache/datafusion-spark/pull/323#issuecomment-6923717922
Besides the `datafusion*` grouping question above:
1. **Library version requirements.** `datafusion-spark` is a library, so
raising a minimum in `Cargo.toml` (for example `tokio = "1.52"` to `"1.53"`)
forces the same floor on downstream users such as Comet. Dependabot's default
`auto` strategy tries to tell libraries from apps, but I haven't checked which
way it classifies this workspace. Setting it explicitly makes minor and patch
updates move only `Cargo.lock` when the current requirement already allows the
new version:
```yaml
versioning-strategy: increase-if-necessary
```
2. **MSRV.** The workspace declares `rust-version = "1.95.0"`, but CI only
builds on stable. A Dependabot update that needs a newer Rust would pass CI and
quietly break the MSRV. A `cargo check` job on 1.95 would catch it. That could
be a follow-up.
3. Nit: `target-branch: main` is the default branch, so the line can go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]