snmvaughan commented on PR #7515: URL: https://github.com/apache/datafusion-comet/pull/7515#issuecomment-6925196019
Thanks for the backport. The diff matches #6178 apart from one context line, and the new tests cover the dispatch guard well. One scope question. `CometCast.isSupported` still treats a `MapType` to `MapType` cast as supported when the key and value casts are, and the native `cast_map_to_map` builds its entries with `StructArray::try_new`, whose key field is non-nullable. Is that path reachable for something like `SELECT try_cast(m AS map<int, int>) FROM t` on a Parquet column? If so, does it error where Spark returns the null-key map? If it is reachable, could we file an issue against `main` so the fix can be backported together? If the plan declines it earlier, a short SQL test pinning the fallback would make that clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
