snmvaughan commented on PR #7513: URL: https://github.com/apache/datafusion-comet/pull/7513#issuecomment-6925196649
Thanks for the backport. The diff matches #6928, and the planner and both benches are updated for the new `try_new` signature. `branch-1.2` commits the generated compat pages (`aggregate.md` under `spark-3.4`, `spark-3.5`, `spark-4.0` and `spark-4.1`), and #7489 updated them for its changed reasons. This PR adds `getCompatibleNotes()` to `CometPercentile`, but the `## Percentile` section on those pages still lists only the unsupported reasons. Could you regenerate them, as #7489 did, so the 1.2 docs show the zero-ordering and pre-3.5.2 caveats? The generator renders them under "The following differences from Spark are always present and do not require any additional configuration:" ahead of the unsupported list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
