stantheman0128 commented on PR #7638: URL: https://github.com/apache/datafusion-comet/pull/7638#issuecomment-6925630878
Spotless is applied on `CometNativeShuffleWriterSuite.scala` only. Head is `ea6a24bf3494d552ee7c1c151864be5f068e93f7`. On this Windows checkout, `dev/copyright/scala-header.txt` is the symlink target text `java-header.txt` (git mode 120000, `core.symlinks` is false). `spotless:apply` against that file would replace Apache headers with that literal string. For the apply I gave Spotless the contents of `dev/copyright/java-header.txt`, limited the run to the two Scala files in this PR, and did not commit the header file. `CometNativeShuffleWriter.scala` was already clean. The suite change is the `stop(false)` constructor layout from the CI Spotless diff. I did not add a test that runs native shuffle. `cargo build -p datafusion-comet --no-default-features` fails in `native/shuffle/src/writers/local/local_partition_writer.rs`: it imports `std::os::unix::fs::FileExt` and calls `read_exact_at`, which this Windows toolchain does not have. No `comet.dll` was produced, so I cannot claim a native shuffle ran. The existing `local.data` and `stop(false)` tests still call the helper and `stop` directly. The `localTempDataFile` wrapper stays until a native run can show `writeInternal` is the path under test. Prepared with Cursor Grok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
