mkleen commented on PR #27064:
URL: https://github.com/apache/datafusion/pull/27064#issuecomment-6926561849

   
   > Have made this change. One thing though- instead of `internal_err`, I am 
raising `not_impl_err` as we do in accumulator. That is the correct error to 
raise or do I need to change it to `internal_err`?
   
   `not_impl_err` seems correct to me. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to