snmvaughan commented on PR #6179:
URL: 
https://github.com/apache/datafusion-comet/pull/6179#issuecomment-6927864720

   Verified end to end on current `main` (`6bd87954c`, Spark 4.1, native 
library built from the same commit), with this PR's head `91dd4208d` merged on 
top.
   
   - `try_cast_map_null_key.sql` passes.
   - The new `CometNativeCastSuite` test, "TRY cast of a map key that can fail 
is Unsupported", passes.
   
   Without the PR, `try_cast(m AS map<int, int>)` over a `map<bigint, int>` 
column holding the key `9999999999` runs natively, as a `CometProject` over a 
`CometNativeScan`, and the query fails in `Native.executePlan` with `Found 
unmasked nulls for non-nullable StructArray field "key"`. With the PR it falls 
back to Spark.
   
   Thanks for the fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to