andygrove commented on PR #26375: URL: https://github.com/apache/datafusion/pull/26375#issuecomment-6928661078
> I personally don't think this PR is necessary as I don't think the new code is any more readable than the old code and changing it just risks introducing new bugs > > Maybe [@andygrove](https://github.com/andygrove) can weigh in as this is being done in his name as he filed > > * [Deduplicate copy-pasted rule families in Simplifier::f_upĀ #26302](https://github.com/apache/datafusion/issues/26302) I agree Sorry for the noise. I'll review the other issues I created and see if they are similarly redundant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
