alamb commented on code in PR #26468:
URL: https://github.com/apache/datafusion/pull/26468#discussion_r4591306323
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -1640,6 +1712,34 @@ fn plan_all_op(
.otherwise(lit(true))
}
+/// Returns true if `expr` is volatile, including any volatile expression
inside
+/// the plan of a subquery it contains.
+///
+/// [`Expr::is_volatile`] treats subqueries as leaves, so it misses a subquery
Review Comment:
Should we instead fix Expr::is_volatile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]