NoahKusaba commented on PR #67:
URL: 
https://github.com/apache/datafusion-iceberg/pull/67#issuecomment-6939495658

   > @NoahKusaba I notice you are working on ballista, do you think we should 
publish a codec here in datafusion-iceberg and share between datafusion 
distributed and ballista the over the wire encoding? I know there's some 
inefficiencies in the encoding (mostly duplicated fields) so I see some benefit 
in optimizing it in 1 place. We have in DFD an implementation of this eager 
data source already, so you can see there how it works.
   
   I definitely considered that when exploring broad refactors of this repo, 
but I wanted to first establish the bones of the ballista-iceberg crate before 
opening that can of worms.
   
   Now that the standalone read PR for ballista is merged in this is definitely 
something worth exploring in the future; however, I'm a bit worried about the 
lack of reviewer bandwidth in this repository / relying on more upstream 
dependencies than necessary (although I suppose Ballista is mainly Andy Grove 
anyway and he can approve here too).
   
   I still need to explore what else needs to be done on Ballista to make 
parallel reads possible on top of this PR, but I'm hopeful there isn't much 
else to add ( I think the "reconstruction of planned scans" follow up is 
necessary, but I haven't dived deep enough to this PR). 
   
   I'm going to transition to focusing on the repo again, but I'm low on time 
for the next 1-2 months. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to