kosiew commented on code in PR #26839:
URL: https://github.com/apache/datafusion/pull/26839#discussion_r4598971409


##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/clustered.rs:
##########
@@ -394,7 +406,10 @@ mod tests {
                 key_types.push(DataType::Timestamp(unit, 
timezone.map(Into::into)));
             }
         }
-        for key_type in key_types {
+        for (key_type_index, key_type) in key_types.into_iter().enumerate() {

Review Comment:
   Optional simplification: could we use 
`key_types.into_iter().skip(shard).step_by(KEY_TYPE_SHARD_COUNT)` instead of 
enumerating and filtering by modulo? This selects the same key types for shards 
0–3 while removing the index and branch. The existing eight matrix cases should 
continue to pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to