NoahKusaba opened a new pull request, #112:
URL: https://github.com/apache/datafusion-iceberg/pull/112

   ## Which issue does this PR close?
   
   - None. A small cleanup of `IcebergDataSource` following the review feedback 
in #67.
   
   ## Rationale for this change
   
   - `IcebergDataSourceBuilder::build()` can fail, so by Rust convention it 
should be `try_build()`, as suggested in #67.
   - `IcebergDataSource` stores its column names in a `projection` field, but 
they are always the field names of its `schema`. Two copies of the same state 
can drift apart.
   
   ## What changes are included in this PR?
   
   - Renames `IcebergDataSourceBuilder::build()` to `try_build()`.
   - Removes the `projection` field and the `projection()` accessor; the column 
names come from `schema()`.
   
   ## Are there any user-facing changes?
   
   Yes: call `try_build()` instead of `build()`, and use `schema()` instead of 
`projection()`.
   
   ## Are these changes tested?
   
   Yes, by the existing scan tests, updated for the new names.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to