andygrove commented on PR #7000: URL: https://github.com/apache/datafusion-comet/pull/7000#issuecomment-6954107412
@comphead I merged `main` again. `CometTextNativeScanExec` landed with Guava's `Objects.hashCode`, as you expected, and it uses `java.util.Objects.hash` now. I also added an enforcer rule, `ban-guava-outside-tests`, that fails the build if Guava reaches the compile or runtime scope, so it cannot come back unnoticed. Everything from your and @sunchao's reviews is addressed. Could you take another look and approve if it looks good? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
