dwsmith1983 commented on PR #5867: URL: https://github.com/apache/datafusion-comet/pull/5867#issuecomment-6955141090
> Could each say what goes through the JVM codegen dispatcher, like the neighbouring Hybrid rows do? Done in 46817f9f8, with the `array_append` note limited to Spark 3.x. I checked each against its serde. `element_at` on an array dispatches under ANSI only when the array itself is nullable and nondeterministic. `m[key]` has only the key-type check, so its note covers just the key types. Variant elements in `arrays_zip` fall back to Spark rather than dispatch, since the dispatcher has no variant support. > Per `backporting.md`, should this go to `branch-1.2`? Yes for #5781. `size`, `arrays_zip` and `map_from_arrays` evaluate a nondeterministic child twice on 1.2 too, while `array_append` and ANSI `element_at` already decline there. I wouldn't backport this PR as is, though. It also moves map lookups with float, collated and complex keys to the dispatcher (#5580). That's an enhancement, and #5875 measured it 9 to 11 percent slower for lookup-only DOUBLE-key projections. #7670 makes those three fall back to Spark on `branch-1.2`, with this PR's SQL tests switched to `expect_fallback`. The run you approved hadn't started its build after two hours, so the new head (with main merged) needs approving again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
