laxmanmamididd commented on PR #7464:
URL: 
https://github.com/apache/datafusion-comet/pull/7464#issuecomment-6956588683

   Thanks, @andygrove. Both updates are in:
   
   - **Docs (9f36bb3f5):** the Lifecycle paragraph in 
`s3-credential-providers.md` now says a provider is retired when the new 
credentials carry a later `s3.session-token-expires-at-ms`, and that otherwise 
the 64-entry bound retires it. The same commit qualifies the examples in the 
`CometS3CredentialProvider.close()` Javadoc, the `CometS3CredentialDispatcher` 
class Javadoc and the `ProviderHandle` comment, which also said re-vended 
credentials retire a provider. These are comment and doc changes only.
   - **PR description:** updated to the expiry rule and the current tests. It 
now lists `cache_keeps_entries_without_a_later_expiry` in place of the removed 
one-sided expiry test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to