alamb commented on code in PR #27224:
URL: https://github.com/apache/datafusion/pull/27224#discussion_r4605595230


##########
datafusion/sqllogictest/test_files/rule_order_join_selection.slt:
##########
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: Apache-2.0
+# SPDX-FileCopyrightText: See the NOTICE file distributed with this work for 
additional information regarding copyright ownership
+# SPDX-FileContributor: Licensed to the Apache Software Foundation (ASF) under 
one or more contributor license agreements
+
+# This file runs `JoinSelection` after `EnsureRequirements` (see `moved_rule` 
in

Review Comment:
   makes sense to me
   
   One thing I think we'll have to sort out is that EXPLAIN plans will likely 
differ if you reorder optimizer passes, so we may have to account for that. But 
we can figure it out when we get there



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to