tlfua commented on issue #7585:
URL: 
https://github.com/apache/datafusion-comet/issues/7585#issuecomment-6961187831

   An update on the two gaps in 
https://github.com/apache/datafusion-comet/issues/7585#issuecomment-6942355561 
, after 
https://github.com/apache/datafusion-comet/pull/7457#pullrequestreview-5939356874
 asked to close the second one in that PR.
   
   1. **The list is incomplete.** 
https://github.com/apache/datafusion-comet/pull/7457 (commits 
ade66196f102207257bd53fa3bae3e6134cf207e and 
d4f087ea5f49567e9dbaa32f2eee4dad46c2295a ) adds `slice` (start 0 or negative 
length), `array_insert` (position 0) and `sequence` with non-constant bounds to 
`raisesInAnyMode`. The others listed there (`regexp_extract` with an invalid 
group index, `array_repeat` past the size limit, `str_to_map` with a duplicate 
key, `make_ym_interval` on overflow) are still open here.
   2. **Session flag vs. eval mode.** Now handled in the same commits: with 
ANSI off, a later sort key that holds a node still in ANSI eval mode, which 
`cannotFail` rejects, makes the TopK fall back. It reads arithmetic and casts 
by their `EvalMode`, plus the `failOnError`/`ansiEnabled` flags of 
`UnaryMinus`, `Abs`, `Round`, `BRound`, `ElementAt`, `GetArrayItem` and `Elt`. 
Other expressions with an ANSI flag, such as `make_date` and `conv`, are not 
covered yet and belong to the shared list this issue proposes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to