andygrove commented on code in PR #334:
URL: https://github.com/apache/datafusion-spark/pull/334#discussion_r4607743064


##########
LICENSE.txt:
##########
@@ -200,3 +200,15 @@
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.
+
+--------------------------------------------------------------------------------
+
+This product includes code translated from fdlibm 5.3 (Freely Distributable
+LIBM), in crates/spark/src/function/math/fdlibm.rs, under the following terms:
+
+  Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved.
+
+  Developed at SunSoft, a Sun Microsystems, Inc. business.
+  Permission to use, copy, modify, and distribute this
+  software is freely granted, provided that this notice
+  is preserved.

Review Comment:
   For context, while we wait on legal-discuss@: arrow already depends on code 
under this same notice. `arrow-array` enables `half`'s `num-traits` feature, 
which enables `num-traits`' `libm` feature. Fifty of `libm`'s source files 
carry the Sun notice, and its LICENSE reproduces it. That is a dependency 
rather than code in our source release, so it does not settle the question 
here. I also checked whether we could use `libm` instead. It differs from 
`StrictMath` on about 1% of `log` inputs and 11% of `log10` inputs, but it 
matches `expm1` exactly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to